Re: [PATCH] drivers/ata: cleanup creation of device sysfs attribute

From: Christoph Hellwig
Date: Sat Jun 08 2019 - 04:31:27 EST

On Fri, Jun 07, 2019 at 10:34:46AM +0300, Konstantin Khlebnikov wrote:
> This patch merges common ATA and AHCI specific attribute "sw_activity"
> into one group with ->is_visible() method which hides attributes if
> feature is not supported by hardware.
> This allows to add all attributes in one place without exporting
> each piece for linking into another list in ahci module.
> Signed-off-by: Konstantin Khlebnikov <khlebnikov@xxxxxxxxxxxxxx>

Looks good,

Reviewed-by: Christoph Hellwig <hch@xxxxxx>