Re: [PATCH v4 01/14] dt-bindings: Add binding for MT2712 MIPI-CSI2
From: Tomasz Figa
Date: Sun Jun 09 2019 - 23:37:11 EST
Hi CK, Stu,
On Mon, Jun 10, 2019 at 11:34 AM CK Hu <ck.hu@xxxxxxxxxxxx> wrote:
> Hi, Stu:
> "mediatek,mt2712-mipicsi" and "mediatek,mt2712-mipicsi-common" have many
> common part with "mediatek,mt8183-seninf", and I've a discussion in ,
> so I would like these two to be merged together.
>  https://patchwork.kernel.org/patch/10979131/
Thanks CK for spotting this.
I also noticed that the driver in fact handles two hardware blocks at
the same time - SenInf and CamSV. Unless the architecture is very
different from MT8183, I'd suggest splitting it.
On a general note, the MT8183 SenInf driver has received several
rounds of review comments already, but I couldn't find any comments
posted for this one.
Given the two aspects above and also based on my quick look at code
added by this series, I'd recommend adding MT2712 support on top of
the MT8183 series.