Re: [PATCH v4 01/14] dt-bindings: Add binding for MT2712 MIPI-CSI2
From: Tomasz Figa
Date: Mon Jun 10 2019 - 04:02:40 EST
On Mon, Jun 10, 2019 at 4:51 PM CK Hu <ck.hu@xxxxxxxxxxxx> wrote:
> Hi, Tomasz:
> On Mon, 2019-06-10 at 12:32 +0900, Tomasz Figa wrote:
> > Hi CK, Stu,
> > On Mon, Jun 10, 2019 at 11:34 AM CK Hu <ck.hu@xxxxxxxxxxxx> wrote:
> > >
> > > Hi, Stu:
> > >
> > > "mediatek,mt2712-mipicsi" and "mediatek,mt2712-mipicsi-common" have many
> > > common part with "mediatek,mt8183-seninf", and I've a discussion in ,
> > > so I would like these two to be merged together.
> > >
> > >  https://patchwork.kernel.org/patch/10979131/
> > >
> > Thanks CK for spotting this.
> > I also noticed that the driver in fact handles two hardware blocks at
> > the same time - SenInf and CamSV. Unless the architecture is very
> > different from MT8183, I'd suggest splitting it.
> > On a general note, the MT8183 SenInf driver has received several
> > rounds of review comments already, but I couldn't find any comments
> > posted for this one.
> > Given the two aspects above and also based on my quick look at code
> > added by this series, I'd recommend adding MT2712 support on top of
> > the MT8183 series.
> In , "mediatek,mt8183-seninf" use one device to control multiple csi
> instance, so it duplicate many register definition. In , one
> "mediatek,mt2712-mipicsi" device control one csi instance, so there are
> multiple device and the register definition does not duplicate.
I guess we didn't catch that in the review yet. It should be fixed.
> recommend adding MT2712 support on top of the MT8183 series, do you mean
> that "mediatek,mt2712-mipicsi" should use one device to control multiple
> csi instance and duplicate the register setting?
There are some aspects of MT8183 series that are done better than the
MT2712 series, but apparently there are also some better aspects in
MT2712. We should take the best aspects of both series. :)
>  https://patchwork.kernel.org/patch/10979121/
>  https://patchwork.kernel.org/patch/10974573/
> > Best regards,
> > Tomasz