Re: [PATCH 1/2] Input: synaptics-rmi4 - clear irqs before set irqs

From: Aaron Ma
Date: Mon Jun 10 2019 - 13:00:37 EST

On 6/10/19 12:55 AM, Dmitry Torokhov wrote:
> Hi Aaron,
> On Wed, Feb 20, 2019 at 05:41:59PM +0100, Aaron Ma wrote:
>> rmi4 got spam data after S3 resume on some ThinkPads.
>> Then TrackPoint lost when be detected by psmouse.
>> Clear irqs status before set irqs will make TrackPoint back.
> Could you please give me an idea as to what this spam data is?

It should be some data 0 during suspend/resume.
Actually I don't know how these data 0 is produced.
Not all synaptics touchpads have this issue.

> In F03 probe we clear all pending data before enabling the function,

Yes we did, but not after resume.

> maybe the same needs to be done on resume, instead of changing the way
> we handle IRQ bits?

This patch is supposed to clear irq status like it in fn probe. Not
changing IRQ bits.


> Thanks,
> -- Dmitry