Re: [PATCH 3/4] arm64: dts: meson: use the generic Ethernet PHY reset GPIO bindings
From: Martin Blumenstingl
Date: Mon Jun 10 2019 - 13:17:12 EST
On Mon, Jun 10, 2019 at 6:54 PM Robin Murphy <robin.murphy@xxxxxxx> wrote:
> Hi Martin,
> On 10/06/2019 17:37, Martin Blumenstingl wrote:
> > The snps,reset-gpio bindings are deprecated in favour of the generic
> > "Ethernet PHY reset" bindings.
> > Replace snps,reset-gpio from the ðmac node with reset-gpios in the
> > ethernet-phy node. The old snps,reset-active-low property is now encoded
> > directly as GPIO flag inside the reset-gpios property.
> > snps,reset-delays-us is converted to reset-assert-us and
> > reset-deassert-us. reset-assert-us is the second cell from
> > snps,reset-delays-us while reset-deassert-us was the third cell.
> > Instead of blindly copying the old values (which seems strange since
> > they gave the PHY one second to come out of reset) over this also
> > updates the delays based on the datasheets:
> > - the Realtek RTL8211F PHY needs a 10ms delay (this applies to the
> > following boards: GXBB NanoPi K2, GXBB Odroid-C2, GXBB Vega S95
> > variants, GXBB Wetek variants, GXL P230, GXM Khadas VIM2, GXM Nexbox
> > A1, GXM Q200, GXM RBox Pro)
> From the datasheets I've seen, RTL8211E/F specify an assert delay of
> 10ms, but a deassert delay of 30ms.
thank you for spotting this!
I don't have an RTL8211F datasheet, but I now see what you mean based
on the RTL8211E datasheet.
now that you pointed this out: it seems that I made a similar mistake
with the IP101GR PHY
The datasheet mentions: "Chip will be able to operate after 2.5ms
delay of the rising edge of RESET_N"
However, further down in the datasheet it states: "Set low to RESET_N
pin, for at least 10ms ..."
I'll wait a few days for more comments and then send a fixed version