Re: [PATCH v4 2/4] x86: simplify _TIF_SYSCALL_EMU handling
From: Thomas Gleixner
Date: Tue Jun 11 2019 - 10:43:20 EST
On Thu, 23 May 2019, Sudeep Holla wrote:
$Subject: Please use the proper prefix and start the sentence with an upper
x86/entry: Simplify _TIF_SYSCALL_EMU handling
> The usage of emulated/_TIF_SYSCALL_EMU flags in syscall_trace_enter
> seems to be bit overcomplicated than required. Let's simplify it.
s/seems to be bit overcomplicated/is more complicated/
Either you are sure that it is overengineered, then say so. If not, then
you should not touch the code at all.
s/Let's simplify it.//
'Let's do X.' is a popular, but technically useless phrase.
> Cc: Andy Lutomirski <luto@xxxxxxxxxx>
> Cc: Thomas Gleixner <tglx@xxxxxxxxxxxxx>
> Cc: Ingo Molnar <mingo@xxxxxxxxxx>
> Cc: Borislav Petkov <bp@xxxxxxxxx>
> Acked-by: Oleg Nesterov <oleg@xxxxxxxxxx>
> Signed-off-by: Sudeep Holla <sudeep.holla@xxxxxxx>
This is a nice simplification indeed! With the changelog fixed:
Reviewed-by: Thomas Gleixner <tglx@xxxxxxxxxxxxx>