On 6/10/19 2:36 PM, Oscar Salvador wrote:
On Tue, 2019-05-28 at 14:44 +0800, Yang Shi wrote:
The commit 9092c71bb724 ("mm: use sc->priority for slab shrinkHi Yang,
has broken up the relationship between sc->nr_scanned and slab
The sc->nr_scanned can't double slab pressure anymore.Â So, it sounds
sense to still keep sc->nr_scanned inc'ed.Â Actually, it would
from adding pressure on slab shrink since excessive sc->nr_scanned
prevent from scan->priority raise.
I might be misunderstanding this, but did you mean "prevent from scan-
I guess we are talking about balance_pgdat(), and in case
kswapd_shrink_node() returns true (it means we have scanned more than
we had to reclaim), raise_priority becomes false, and this does not let
sc->priority to be decreased, which has the impact that less pages will
Â be reclaimed the next round.
Sorry for bugging here, I just wanted to see if I got this right.