Re: [PATCH 16/16] mm: pass get_user_pages_fast iterator arguments in a structure

From: Nicholas Piggin
Date: Tue Jun 11 2019 - 21:00:27 EST

Christoph Hellwig's on June 12, 2019 12:41 am:
> Instead of passing a set of always repeated arguments down the
> get_user_pages_fast iterators, create a struct gup_args to hold them and
> pass that by reference. This leads to an over 100 byte .text size
> reduction for x86-64.

What does this do for performance? I've found this pattern can be
bad for store aliasing detection.