Re: [RFC PATCH] x86/cpufeatures: Enumerate new AVX512 bfloat16 instructions

From: Borislav Petkov
Date: Wed Jun 12 2019 - 00:03:50 EST

On Wed, Jun 12, 2019 at 03:29:57AM +0000, Yu, Fenghua wrote:
> My bad. I studied a bit more and found the patch #1 is not needed.

Why, I think you were spot-on:

"And the two variables are ONLY used in resctrl monitoring
configuration. There is no need to store them in cpuinfo_x86 on each

That was a real overkill to put them in cpuinfo_x86. The information
needed should simply be read out in rdt_get_mon_l3_config() and that's
it - no need to global values to store them.

Now removing them should be in a separate patch so that review is easy.

Or am I missing an aspect?


Good mailing practices for 400: avoid top-posting and trim the reply.