Re: [PATCH 1/3] dt-bindings: imx: Add pinctrl binding doc for i.MX8MN
From: Shawn Guo
Date: Wed Jun 12 2019 - 02:10:45 EST
On Tue, Jun 11, 2019 at 10:00:36AM +0000, Aisheng Dong wrote:
> > From: Linus Walleij [mailto:linus.walleij@xxxxxxxxxx]
> > Sent: Saturday, June 8, 2019 5:04 AM
> > On Thu, May 30, 2019 at 5:04 AM <Anson.Huang@xxxxxxx> wrote:
> > > From: Anson Huang <Anson.Huang@xxxxxxx>
> > >
> > > Add binding doc for i.MX8MN pinctrl driver.
> > >
> > > Signed-off-by: Anson Huang <Anson.Huang@xxxxxxx>
> > Looks mostly OK to me, but I'd like the maintainers to review, so Dong et al
> > please look at this!
> > > +Required properties:
> > > +- compatible: "fsl,imx8mn-iomuxc"
> > So should this not be "nxp,imx8mn-iomuxc"
> > or "nxp,freescale-imx8mn-iomuxc" or something these days? The vendor name
> > is nxp is it not.
> > I was complaining to the DT maintainers at one point that these companies
> > seem to buy each other left and right so this vendor nomenclature is dubious,
> > but I guess at least it should reflect the vendor that produced the chip or
> > something.
> > If everyone is happy with "fsl,*" I will not complain though.
> > (i.e. if the maintainers ACK it.)
> We preferred to keep "fsl,*" for Freescale i.MX product line according to last discussion.
> And we already did this way for most i.MX devices.
We do not see serious problem with 'fsl' prefix, so would rather stay