Re: [PATCH][next] video: fbdev: atmel_lcdfb: remove redundant initialization to variable ret

[Nicolas.Ferre]

On 11/06/2019 at 19:09, Colin King wrote:
> External E-Mail
> 
> 
> From: Colin Ian King <colin.king@xxxxxxxxxxxxx>
> 
> Currently variable ret is being initialized with -ENOENT however that
> value is never read and ret is being re-assigned later on. Hence this
> assignment is redundant and can be removed.
> 
> Addresses-Coverity: ("Unused value")
> Signed-off-by: Colin Ian King <colin.king@xxxxxxxxxxxxx>

Indeed:
Acked-by: Nicolas Ferre <nicolas.ferre@xxxxxxxxxxxxx>

Thanks, best regards,
   Nicolas


> ---
>   drivers/video/fbdev/atmel_lcdfb.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/video/fbdev/atmel_lcdfb.c b/drivers/video/fbdev/atmel_lcdfb.c
> index fb117ccbeab3..930cc3f92e01 100644
> --- a/drivers/video/fbdev/atmel_lcdfb.c
> +++ b/drivers/video/fbdev/atmel_lcdfb.c
> @@ -950,7 +950,7 @@ static int atmel_lcdfb_of_init(struct atmel_lcdfb_info *sinfo)
>   	struct fb_videomode fb_vm;
>   	struct gpio_desc *gpiod;
>   	struct videomode vm;
> -	int ret = -ENOENT;
> +	int ret;
>   	int i;
>   
>   	sinfo->config = (struct atmel_lcdfb_config*)
> 


-- 
Nicolas Ferre