Re: [PATCH v3 3/5] brcmfmac: sdio: Disable auto-tuning around commands expected to fail

From: Arend Van Spriel
Date: Wed Jun 12 2019 - 07:16:29 EST

On 6/12/2019 12:10 PM, Ulf Hansson wrote:
mmc_set_data_timeout(md, func->card);
mmc_wait_for_req(func->card->host, mr);
These are not okay, none of these things calls should really be done
from an SDIO func driver.

It tells me that the func driver is a doing workaround for something
that should be managed in a common way.

We are using some low-level functions passing chain of skbuff to the device using CMD53 with scatterlist. If I recall correctly Marvell made an attempt to have a similar function for it in the mmc stack. Not sure if that ever made it in. If so I can rework our driver using that API. If not, I can make a new attempt.