Re: [PATCH] vmw_ballon: no need to check return value of debugfs_create functions

From: Greg Kroah-Hartman
Date: Wed Jun 12 2019 - 07:40:18 EST

On Tue, Jun 11, 2019 at 07:36:36PM +0000, Nadav Amit wrote:
> Please change the title of the patch to âvmw_balloonâ (it is currently
> âvmw_ballonâ).

Oops, will fix, sorry about that.

> > On Jun 11, 2019, at 11:55 AM, Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx> wrote:
> >
> > When calling debugfs functions, there is no need to ever check the
> > return value. The function can work or not, but the code logic should
> > never do something different based on this.
> I remember I saw a discussion about it, and didnât know the resolution.
> If that's the decision (assuming debugfs initialization always succeeds),
> and after fixing the title of the patch:
> Acked-by: Nadav Amit <namit@xxxxxxxxxx>

Thanks for the review!

greg k-h