Re: [PATCH] lkdtm: no need to check return value of debugfs_create functions

From: Greg Kroah-Hartman
Date: Wed Jun 12 2019 - 07:41:11 EST


On Tue, Jun 11, 2019 at 01:43:56PM -0700, Kees Cook wrote:
> On Tue, Jun 11, 2019 at 08:32:13PM +0200, Greg Kroah-Hartman wrote:
> > When calling debugfs functions, there is no need to ever check the
> > return value. The function can work or not, but the code logic should
> > never do something different based on this.
> >
> > Cc: Kees Cook <keescook@xxxxxxxxxxxx>
> > Cc: Arnd Bergmann <arnd@xxxxxxxx>
> > Cc: linux-kernel@xxxxxxxxxxxxxxx
> > Signed-off-by: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>
>
> Acked-by: Kees Cook <keescook@xxxxxxxxxxxx>

Thanks for the review!

greg k-h