Re: [PATCH] fuse: require /dev/fuse reads to have enough buffer capacity (take 2)
From: Sander Eikelenboom
Date: Wed Jun 12 2019 - 12:29:44 EST
On 12/06/2019 16:12, Kirill Smelkov wrote:
> On Wed, Jun 12, 2019 at 03:03:49PM +0200, Sander Eikelenboom wrote:
>> On 12/06/2019 13:25, Kirill Smelkov wrote:
>>> On Wed, Jun 12, 2019 at 09:44:49AM +0200, Miklos Szeredi wrote:
>>>> On Tue, Jun 11, 2019 at 10:28 PM Kirill Smelkov <kirr@xxxxxxxxxx> wrote:
>>>>> Miklos, would 4K -> `sizeof(fuse_in_header) + sizeof(fuse_write_in)` for
>>>>> header room change be accepted?
>>>> Yes, next cycle. For 4.2 I'll just push the revert.
>>> Thanks Miklos. Please consider queuing the following patch for 5.3.
>>> Sander, could you please confirm that glusterfs is not broken with this
>>> version of the check?
>>> Thanks beforehand,
>> Hmm unfortunately it doesn't build, see below.
>> fs/fuse/dev.c:1336:14: error: âfuse_in_headerâ undeclared (first use in this function)
>> sizeof(fuse_in_header) + sizeof(fuse_write_in) + fc->max_write))
> Sorry, my bad, it was missing "struct" before fuse_in_header. I
> originally compile-tested the patch with `make -j4`, was distracted onto
> other topic and did not see the error after returning due to long tail
> of successful CC lines. Apologize for the inconvenience. Below is a
> fixed patch that was both compile-tested and runtime-tested with my FUSE
> workloads (non-glusterfs).
Just tested and it works for me, thanks !