Re: [PATCH -next] ima: Make arch_policy_entry static

From: Mimi Zohar
Date: Thu Jun 13 2019 - 11:43:17 EST


On Tue, 2019-06-11 at 21:40 +0800, YueHaibing wrote:
> Fix sparse warning:
>
> security/integrity/ima/ima_policy.c:202:23: warning:
> symbol 'arch_policy_entry' was not declared. Should it be static?
>
> Reported-by: Hulk Robot <hulkci@xxxxxxxxxx>
> Signed-off-by: YueHaibing <yuehaibing@xxxxxxxxxx>

Thanks, this patch has been queued to be upstreamed.

Mimi

> ---
> security/integrity/ima/ima_policy.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/security/integrity/ima/ima_policy.c b/security/integrity/ima/ima_policy.c
> index 1cc822a..cd1b728 100644
> --- a/security/integrity/ima/ima_policy.c
> +++ b/security/integrity/ima/ima_policy.c
> @@ -199,7 +199,7 @@ static struct ima_rule_entry secure_boot_rules[] __ro_after_init = {
> };
>
> /* An array of architecture specific rules */
> -struct ima_rule_entry *arch_policy_entry __ro_after_init;
> +static struct ima_rule_entry *arch_policy_entry __ro_after_init;
>
> static LIST_HEAD(ima_default_rules);
> static LIST_HEAD(ima_policy_rules);