Re: [PATCH v2] PCI: aardvark: Fix PCI_EXP_RTCTL conf register writing

From: Thomas Petazzoni
Date: Fri Jun 14 2019 - 05:03:52 EST


On Fri, 14 Jun 2019 08:42:25 +0200
Remi Pommarel <repk@xxxxxxxxxxxx> wrote:

> PCI_EXP_RTCTL is used to activate PME interrupt only, so writing into it
> should not modify other interrupts' mask. The ISR mask polarity was also
> inverted, when PCI_EXP_RTCTL_PMEIE is set PCIE_MSG_PM_PME_MASK mask bit
> should actually be cleared.
> Fixes: 6302bf3ef78d ("PCI: Init PCIe feature bits for managed host bridge alloc")

Are you sure about this Fixes tag ? This commit seems unrelated.

The commit introducing this issue is 8a3ebd8de328301aacbe328650a59253be2ac82c.

Best regards,

Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering