Re: [PATCH v2] memory: tegra: Fix -Wunused-const-variable

From: Thierry Reding
Date: Fri Jun 14 2019 - 12:07:26 EST


On Thu, Jun 13, 2019 at 11:26:10AM -0700, Nathan Huckleberry wrote:
> Clang produces the following warning
>
> drivers/memory/tegra/tegra124.c:36:28: warning: unused variable
> 'tegra124_mc_emem_regs' [-Wunused-const-variable]
> static const unsigned long tegra124_mc_emem_regs[] = {
> ^
>
> The only usage of this variable is from within an ifdef.
> It seems logical to move the variable into the ifdef as well.
>
> Cc: clang-built-linux@xxxxxxxxxxxxxxxx
> Link: https://github.com/ClangBuiltLinux/linux/issues/526
> Signed-off-by: Nathan Huckleberry <nhuck@xxxxxxxxxx>
> ---
> Changes from v1 -> v2:
> * Moved definition of tegra124_mc_emem_regs into existing ifdef
> drivers/memory/tegra/tegra124.c | 44 ++++++++++++++++-----------------
> 1 file changed, 22 insertions(+), 22 deletions(-)

Applied, thanks.

Thierry

Attachment: signature.asc
Description: PGP signature