Re: [PATCH v2] i2c: i2c-stm32f7: fix the get_irq error cases

From: Wolfram Sang
Date: Fri Jun 14 2019 - 16:58:13 EST


Hi Fabrice,

> + return irq_event ? irq_event : -ENODEV;

Maybe -ENOENT instead of -ENODEV? I mean you have a dev_err there, so
the driver core should probably also complain?

You could also shorten the ternary operator to:

return irq_event ? : -E<whatyouprefer>;

However, both are minor nits. If you prefer to keep the patch as is,
fine with me.

Regards,

Wolfram

Attachment: signature.asc
Description: PGP signature