Re: [PATCH v2] soc: qcom: apr: Don't use reg for domain id

From: Bjorn Andersson
Date: Sat Jun 15 2019 - 03:11:56 EST


On Fri 14 Jun 09:57 PDT 2019, Rob Herring wrote:

> On Thu, 23 May 2019 08:01:53 -0700, Bjorn Andersson wrote:
> > The reg property represents the address and size on the bus that a
> > device lives, but for APR the parent is a rpmsg bus, which does not have
> > numerical addresses. Simply defining #address/#size-cells to 1 and 0,
> > respectively, to silence the compiler is not an appropriate solution.
> >
> > Replace the use of "reg" with an APR specific property.
> >
> > Reviewed-by: Srinivas Kandagatla <srinivas.kandagatla@xxxxxxxxxx>
> > Signed-off-by: Bjorn Andersson <bjorn.andersson@xxxxxxxxxx>
> > ---
> >
> > Changes since v1:
> > - Fixed example to match change
> >
> > Documentation/devicetree/bindings/soc/qcom/qcom,apr.txt | 6 +++---
> > drivers/soc/qcom/apr.c | 2 +-
> > 2 files changed, 4 insertions(+), 4 deletions(-)
> >
>
> Reviewed-by: Rob Herring <robh@xxxxxxxxxx>

Thanks Rob, patch applied.

Regards,
Bjorn