Re: [PATCH v4 0/3] livepatch: Cleanup of reliable stacktrace warnings

From: Josh Poimboeuf
Date: Sat Jun 15 2019 - 16:48:19 EST


On Tue, Jun 11, 2019 at 04:13:17PM +0200, Miroslav Benes wrote:
> This is the fourth attempt to improve the situation of reliable stack
> trace warnings in livepatch. Based on discussion in
> 20190531074147.27616-1-pmladek@xxxxxxxx (v3).
>
> Changes against v3:
> + weak save_stack_trace_tsk_reliable() removed, because it is not needed
> anymore thanks to Thomas' recent improvements
> + klp_have_reliable_stack() check reintroduced in klp_try_switch_task()
>
> Changes against v2:
>
> + Put back the patch removing WARN_ONCE in the weak
> save_stack_trace_tsk_reliable(). It is related.
> + Simplified patch removing the duplicate warning from klp_check_stack()
> + Update commit message for 3rd patch [Josh]
>
> Miroslav Benes (2):
> stacktrace: Remove weak version of save_stack_trace_tsk_reliable()
> Revert "livepatch: Remove reliable stacktrace check in
> klp_try_switch_task()"
>
> Petr Mladek (1):
> livepatch: Remove duplicate warning about missing reliable stacktrace
> support
>
> kernel/livepatch/transition.c | 8 +++++++-
> kernel/stacktrace.c | 8 --------
> 2 files changed, 7 insertions(+), 9 deletions(-)

Thanks Miroslav for wrapping this up, and thanks to Petr for his
previous work on this.

Acked-by: Josh Poimboeuf <jpoimboe@xxxxxxxxxx>

--
Josh