Re: [PATCH 14/14] docs: sphinx/kernel_abi.py: fix UTF-8 support

From: Markus Heiser
Date: Sun Jun 16 2019 - 11:48:46 EST



Am 14.06.19 um 18:25 schrieb Mauro Carvalho Chehab:
Em Fri, 14 Jun 2019 18:18:37 +0200
Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx> escreveu:

On Thu, Jun 13, 2019 at 11:04:20PM -0300, Mauro Carvalho Chehab wrote:
The parser breaks with UTF-8 characters with Sphinx 1.4.

Signed-off-by: Mauro Carvalho Chehab <mchehab+samsung@xxxxxxxxxx>
---
Documentation/sphinx/kernel_abi.py | 10 ++++++----
1 file changed, 6 insertions(+), 4 deletions(-)

diff --git a/Documentation/sphinx/kernel_abi.py b/Documentation/sphinx/kernel_abi.py
index 7fa7806532dc..460cee48a245 100644
--- a/Documentation/sphinx/kernel_abi.py
+++ b/Documentation/sphinx/kernel_abi.py
@@ -1,4 +1,5 @@
-# -*- coding: utf-8; mode: python -*-
+# coding=utf-8
+#

Is this an emacs vs. vim fight?

No. This is a python-specific thing:

https://www.python.org/dev/peps/pep-0263/

No need to change, the emacs notation is also OK, see your link

"""or (using formats recognized by popular editors):"""

https://www.python.org/dev/peps/pep-0263/#defining-the-encoding

I prefer emacs notation, this is also evaluated by many other editors / tools.

-- Markus --