Re: [PATCH 4.19 017/118] thermal: rcar_gen3_thermal: disable interrupt in .remove
From: Pavel Machek
Date: Sun Jun 16 2019 - 15:46:23 EST
stable removed from cc.
On Thu 2019-06-13 10:32:35, Greg Kroah-Hartman wrote:
> [ Upstream commit 63f55fcea50c25ae5ad45af92d08dae3b84534c2 ]
> Currently IRQ remains enabled after .remove, later if device is probed,
> IRQ is requested before .thermal_init, this may cause IRQ function be
> called before device is initialized.
> this patch disables interrupt in .remove, to ensure irq function
> only be called after device is fully initialized.
Well, I guess this fixes your problem, but it does not seem like a
Could .init be reordered so that you initialize hardware, first, and
only then request irq? That should solve the problem in a reliable
> +++ b/drivers/thermal/rcar_gen3_thermal.c
> @@ -328,6 +328,9 @@ MODULE_DEVICE_TABLE(of, rcar_gen3_thermal_dt_ids);
> static int rcar_gen3_thermal_remove(struct platform_device *pdev)
> struct device *dev = &pdev->dev;
> + struct rcar_gen3_thermal_priv *priv = dev_get_drvdata(dev);
> + rcar_thermal_irq_set(priv, false);
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
Description: Digital signature