Re: [PATCH net-next] net: ethernet: ti: davinci_cpdma: use idled submit

From: David Miller
Date: Sun Jun 16 2019 - 17:08:32 EST

From: Ivan Khoronzhuk <ivan.khoronzhuk@xxxxxxxxxx>
Date: Sat, 15 Jun 2019 14:01:32 +0300

> While data pass suspend, reuse of rx descriptors can be disabled using
> channel state & lock from cpdma layer. For this, submit to a channel
> has to be disabled using state != "not active" under lock, what is done
> with this patch. The same submit is used to fill rx channel while
> ndo_open, when channel is idled, so add idled submit routine that
> allows to prepare descs for the channel. All this simplifies code and
> helps to avoid dormant mode usage and send packets only to active
> channels, avoiding potential race in later on changes. Also add missed
> sync barrier analogically like in other places after stopping tx
> queues.
> Signed-off-by: Ivan Khoronzhuk <ivan.khoronzhuk@xxxxxxxxxx>