Re: [PATCH 1/3] x86/resctrl: Get max rmid and occupancy scale directly from CPUID instead of cpuinfo_x86

From: Borislav Petkov
Date: Mon Jun 17 2019 - 04:35:46 EST

On Mon, Jun 17, 2019 at 01:09:09AM -0700, Fenghua Yu wrote:
> I just keep the code a bit uniform around the calling area where
> a few functions are called. So get_cqm_info() makes the code a bit more
> readable.
> init_scattered_cpuid_features(c);
> init_speculation_control(c);
> + get_cqm_info(c);
> /*
> * Clear/Set all flags overridden by options, after probe.
> * This needs to happen each time we re-probe, which may happen
> * several times during CPU initialization.
> */
> apply_forced_caps(c);
> }
> Maybe not? If the function is not good, I can directly put the code here?

If you want to have it cleaner, make that a separate patch and say so in
the commit message. Patches should do one logical thing and not mix up
different changes which makes review harder.


Good mailing practices for 400: avoid top-posting and trim the reply.