Re: [PATCH v2 0/2] Add macb support for SiFive FU540-C000
From: Yash Shah
Date: Mon Jun 17 2019 - 06:27:48 EST
On Mon, Jun 17, 2019 at 3:28 PM Paul Walmsley <paul.walmsley@xxxxxxxxxx> wrote:
> Hi Yash,
> On Mon, 17 Jun 2019, Andreas Schwab wrote:
> > On Jun 17 2019, Yash Shah <yash.shah@xxxxxxxxxx> wrote:
> > > - Add "MACB_SIFIVE_FU540" in Kconfig to support SiFive FU540 in macb
> > > driver. This is needed because on FU540, the macb driver depends on
> > > SiFive GPIO driver.
> > This of course requires that the GPIO driver is upstreamed first.
> What's the impact of enabling CONFIG_MACB_SIFIVE_FU540 when the GPIO
> driver isn't present? (After modifying the Kconfig "depends" line
> Looks to me that it shouldn't have an impact unless the DT string is
> present, and even then, the impact might simply be that the MACB driver
> may not work?
Yes, there won't be an impact other than MACB driver not working.
In any case, without GPIO driver, PHY won't get reset and the network
interface won't come up.
> - Paul