Re: [PATCH] integrity: Fix __integrity_init_keyring() section mismatch

From: Nayna
Date: Mon Jun 17 2019 - 10:09:59 EST

On 06/17/2019 03:44 AM, Geert Uytterhoeven wrote:
With gcc-4.6.3:

WARNING: vmlinux.o(.text.unlikely+0x24c64): Section mismatch in reference from the function __integrity_init_keyring() to the function .init.text:set_platform_trusted_keys()
The function __integrity_init_keyring() references
the function __init set_platform_trusted_keys().
This is often because __integrity_init_keyring lacks a __init
annotation or the annotation of set_platform_trusted_keys is wrong.

Indeed, if the compiler decides not to inline __integrity_init_keyring(),
a warning is issued.

Fix this by adding the missing __init annotation.

Fixes: 9dc92c45177ab70e ("integrity: Define a trusted platform keyring")
Signed-off-by: Geert Uytterhoeven <geert@xxxxxxxxxxxxxx>

Thanks for fixing it.

Reviewed-by: Nayna Jain <nayna@xxxxxxxxxxxxx>

Thanks & Regards,