Re: [PATCH v3 0/6] sched: Add new tracepoints required for EAS testing
From: Peter Zijlstra
Date: Mon Jun 17 2019 - 12:01:06 EST
On Mon, Jun 17, 2019 at 01:51:23PM +0100, Qais Yousef wrote:
> Hi Peter
> On 06/04/19 12:14, Qais Yousef wrote:
> > Changes in v3:
> > - Split pelt_rq TP into pelt_cfs, pelt_rq, pelt_dl and pelt_irq
> > - Replace the fatty preprocessing wrappers with exported helper
> > functions to access data in unexported structures.
> > - Remove the now unnecessary headers that were introduced in the
> > previous versions.
> > - Postfix the tracepoints with '_tp' to make them standout more in the
> > code as bare tracepoints with no events associated.
> > - Updated the example module in 
> > - It demonstrates now how to convert the tracepoints into trace
> > events that extend the sched events subsystem in tracefs.
> Does this look okay now? If you have further comments please let me know so
> I can address them in time in hope it'd make it to the next merge window.
Picked them up (with some minor edits). I feel there is far too much
#ifdef in patch #2, but I couldn't quickly come up with anything much