Re: [PATCH] [RFC] get_maintainer: Really limit regex patterns to words

From: Joe Perches
Date: Mon Jun 17 2019 - 12:22:41 EST

On Mon, 2019-06-17 at 16:23 +0200, Geert Uytterhoeven wrote:
> Limit file and directory regex matching to paths that contain the
> pattern as a word, i.e. that contain word boundaries before and after
> the pattern. This helps avoiding false positives.
> Without this, e.g. "scripts/ -f
> tools/perf/pmu-events/arch/x86/westmereex" lists the STM32 maintainers,
> due to the presence of "stm" in the middle of a word in the path name.
> Signed-off-by: Geert Uytterhoeven <geert+renesas@xxxxxxxxx>
> ---
> What to do with drivers/pwm/pwm-stmpe.c, which is no longer caught?
> Add a new pattern to MAINTAINERS?

Hi Geert

> diff --git a/scripts/ b/scripts/
> @@ -884,7 +884,7 @@ sub get_maintainers {
> }
> }
> } elsif ($type eq 'N') {
> - if ($file =~ m/$value/x) {
> + if ($file =~ m/\b$value\b/x) {

I'm not sure this is the right approach as it also
affects regexes like
"N: rockchip" where there
are multiple current matches that wouldn't
work anymore.

It might be better to change the regexes in MAINTAINERS
where appropriate.

There is also a regex with a directory slash so it's
probably better to use m{<foo>}