Re: [PATCH] fib_semantics: Fix warning in fib_check_nh_v4_gw

From: David Ahern
Date: Mon Jun 17 2019 - 13:17:14 EST


On 6/17/19 4:21 AM, Vincenzo Frascino wrote:
> Currently, the err variable in fib_check_nh_v4_gw may be used
> uninitialized leading to the warning below:
>
> fib_semantics.c: In function âfib_check_nh_v4_gwâ:
> fib_semantics.c:1023:12: warning: âerrâ may be used
> uninitialised in this function [-Wmaybe-uninitialized]
> if (!tbl || err) {
> ^~
>
> Initialize err to 0 to fix the warning.
>
> Cc: "David S. Miller" <davem@xxxxxxxxxxxxx>
> Cc: Alexey Kuznetsov <kuznet@xxxxxxxxxxxxx>
> Cc: Hideaki YOSHIFUJI <yoshfuji@xxxxxxxxxxxxxx>
> Signed-off-by: Vincenzo Frascino <vincenzo.frascino@xxxxxxx>
> ---
> net/ipv4/fib_semantics.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>

already fixed in net; will make it to net-next on next merge.