Re: [PATCH 08/25] memremap: move dev_pagemap callbacks into a separate structure
From: Christoph Hellwig
Date: Mon Jun 17 2019 - 16:15:31 EST
On Mon, Jun 17, 2019 at 02:08:14PM -0600, Logan Gunthorpe wrote:
> I just noticed this is missing a line to set pgmap->ops to
> pci_p2pdma_pagemap_ops. I must have gotten confused by the other users
> in my original review. Though I'm not sure how this compiles as the new
> struct is static and unused. However, it is rendered moot in Patch 16
> when this is all removed.
It probably was there in the original and got lost in the merge conflicts
from the rebase. I should have dropped all the reviewed-bys for patches
with non-trivial merge resolution, sorry.