Re: [PATCH RESEND] fs: cramfs_fs.h: Fix shifting signed 32-bit value by 31 bits problem

From: Christoph Hellwig
Date: Tue Jun 18 2019 - 03:04:23 EST


> -#define CRAMFS_BLK_FLAG_UNCOMPRESSED (1 << 31)
> +#define CRAMFS_BLK_FLAG_UNCOMPRESSED (1U << 31)
> #define CRAMFS_BLK_FLAG_DIRECT_PTR (1 << 30)

Please use the unsigned constants for all flags, not just one.