Re: [PATCH 2/5] Powerpc/hw-breakpoint: Refactor hw_breakpoint_arch_parse()
From: Ravi Bangoria
Date: Tue Jun 18 2019 - 03:16:06 EST
On 6/18/19 11:51 AM, Christophe Leroy wrote:
> Le 18/06/2019 Ã 06:27, Ravi Bangoria a ÃcritÂ:
>> Move feature availability check at the start of the function.
>> Rearrange comment to it's associated code. Use hw->address and
>> hw->len in the 512 bytes boundary check(to write if statement
>> in a single line). Add spacing between code blocks.
> Are those cosmetic changes in the boundary check worth it since they disappear in the final patch ?
Nope.. not necessary. I was just going bit more patch by patch.
I don't mind keeping the code as it is and then change it in
the final patch.