Re: [PATCH] irqchip/mbigen: stop printing kernel addresses
From: Hanjun Guo
Date: Tue Jun 18 2019 - 04:05:22 EST
On 2019/6/18 11:22, Kefeng Wang wrote:
> After commit ad67b74d2469d9b8 ("printk: hash addresses printed with %p"),
> it will print "____ptrval____" instead of actual addresses when mbigen
> create domain fails,
> Hisilicon MBIGEN-V2 HISI0152:00: Failed to create mbi-gen@(____ptrval____) irqdomain
> Hisilicon MBIGEN-V2: probe of HISI0152:00 failed with error -12
> Instead of changing the print to "%px", and leaking kernel addresses,
> just remove the print completely.
This is a little bit misleading, as the "base" was used for
identify which mbigen failed, so saying 'remove completely'
will make people think that we will miss some debug information.
In fact, we have HISI0152:00 stands for mbigen ACPI HID and
its UID, so we can identify the failing probed mbigen even
we remove the printing "mgn_chip->base". It's better to add
this clarify in the commit message as well.