Re: [PATCH] sched/topology: remove unused sd param from arch_scale_cpu_capacity()

[Peter Zijlstra]

On Mon, Jun 17, 2019 at 06:07:29PM +0100, Valentin Schneider wrote:
> Hi,
> 
> On 17/06/2019 16:00, Vincent Guittot wrote:
> > struct sched_domain *sd parameter is not used anymore in
> > arch_scale_cpu_capacity() so we can remove it.
> > 
> 
> I think it can't hurt to give a bit of background. The *sd parameter used
> to be there for smt_gain, which got snipped out by:
> 
>   765d0af19f5f ("sched/topology: Remove the ::smt_gain field from 'struct sched_domain'")
> 
> I'd appreciate having that commit mentioned in the log.
> 
> > Signed-off-by: Vincent Guittot <vincent.guittot@xxxxxxxxxx>
> 
> Other than that, the changes look fine to me.
> 
> Reviewed-by: Valentin Schneider <valentin.schneider@xxxxxxx>

The commit log now reads:

---
The 'struct sched_domain *sd' argument to arch_scale_cpu_capacity() is
unused since commit:

  765d0af19f5f ("sched/topology: Remove the ::smt_gain field from 'struct sched_domain'")

remove it.
---