Re: [PATCH] soc: ixp4xx: npe: Fix an IS_ERR() vs NULL check in probe

From: Linus Walleij
Date: Tue Jun 18 2019 - 07:40:34 EST

On Thu, Jun 13, 2019 at 9:02 AM Dan Carpenter <dan.carpenter@xxxxxxxxxx> wrote:

> The devm_ioremap_resource() function doesn't return NULL, it returns
> error pointers.
> Fixes: 0b458d7b10f8 ("soc: ixp4xx: npe: Pass addresses as resources")
> Signed-off-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx>

Reviewed-by: Linus Walleij <linus.walleij@xxxxxxxxxx>

Can you please collect my review and send this to the ARM SoC maintainers
arm@xxxxxxxxxx since they are collecting a few other IXP4xx fixes?

Linus Walleij