Re: [PATCH V9] i2c: tegra: remove BUG() macro

From: Bitan Biswas
Date: Tue Jun 18 2019 - 07:57:48 EST

On 6/18/19 4:29 AM, Dmitry Osipenko wrote:
18.06.2019 14:09, Bitan Biswas ÐÐÑÐÑ:
The usage of BUG() macro is generally discouraged in kernel, unless
it's a problem that results in a physical damage or loss of data.
This patch removes unnecessary BUG() macros and replaces the rest
with warning.

Signed-off-by: Bitan Biswas <bbiswas@xxxxxxxxxx>
drivers/i2c/busses/i2c-tegra.c | 47 +++++++++++++++++++++++++++++++++++-------
1 file changed, 39 insertions(+), 8 deletions(-)

Thank you very much! Please keep applying all the advises that were given to you
during the reviews in the future patches.
Thank you Dmitry for the review inputs and patience. I shall try to keep the advices in mind for future reviews.

I made a quick test and no problems spotted, all warning spots are silent.

Reviewed-by: Dmitry Osipenko <digetx@xxxxxxxxx>
Tested-by: Dmitry Osipenko <digetx@xxxxxxxxx>

Also, Thank you for help in testing the patch at your end.