Re: [PATCH v2 1/8] regulator: core: Introduce API for regulators coupling customization

From: Dmitry Osipenko
Date: Tue Jun 18 2019 - 12:30:54 EST


17.06.2019 18:23, Mark Brown ÐÐÑÐÑ:
> On Tue, Jun 04, 2019 at 02:58:57AM +0300, Dmitry Osipenko wrote:
>> Right now regulator core supports only one type of regulators coupling,
>> the "voltage max-spread" which keeps voltages of coupled regulators in a
>> given range from each other. A more sophisticated coupling may be required
>> in practice, one example is the NVIDIA Tegra SoC's which besides the
>> max-spreading have other restrictions that must be adhered. Introduce API
>> that allow platforms to provide their own customized coupling algorithms.
>
> So, I don't completely hate this and I'm not sure there's any good
> solutions here...

Thanks!

>> + * @balance_voltage: Callback invoked when voltage of a coupled regulator is
>> + * changing. The callee should perform voltage balancing
>> + * and change voltage of the coupled regulators.
>
> Some documentation on what the context for calling this is (locking and
> so on) and how it should do the adjustments it wants to do would be
> good.
>

Okay, I'll extend the doc.