RE: [PATCH 1/6] net: macb: add phylink support

From: Parshuram Raju Thombare
Date: Tue Jun 18 2019 - 14:27:33 EST


>> @@ -4217,8 +4257,8 @@ static int macb_probe(struct platform_device *pdev)
>>
>> tasklet_init(&bp->hresp_err_tasklet, macb_hresp_error_task,
>> (unsigned long)bp);
>> -
>> - phy_attached_info(phydev);
>> + if (dev->phydev)
>> + phy_attached_info(dev->phydev);
>
>When can this happen? I don't see anything assigning to dev->phydev.
This is for non sfp (MDIO) based PHY. It is set in phy_attach_direct (phylink_connect_phy -> __ phylink_connect_phy -> phy_attach_direct)
>
> Andrew

Regards,
Parshuram Thombare