Re: [PATCH 1/2] drm/vkms: Use index instead of 0 in possible crtc

From: Rodrigo Siqueira
Date: Tue Jun 18 2019 - 17:56:34 EST


On Tue, Jun 18, 2019 at 2:18 AM Simon Ser <contact@xxxxxxxxxxx> wrote:
>
> On Tuesday, June 18, 2019 5:19 AM, Rodrigo Siqueira <rodrigosiqueiramelo@xxxxxxxxx> wrote:
> > I made the patch, but when I started to write the commit message, I just
> > realized that I did not understand why possible_crtcs should not be
> > equal zero. Why can we not use zero?
>
> Hi,
>
> possible_crtcs is a bitfield. If it's zero, it means the plane cannot
> be attached to any CRTC, which makes it rather useless.

Hi,

Thank you very much for your explanation. I'll try to finish the patch.

> Thanks,
>
> Simon



--

Rodrigo Siqueira
https://siqueira.tech