Re: [PATCH] scsi: mpt3sas: Mark expected switch fall-through

From: Martin K. Petersen
Date: Tue Jun 18 2019 - 21:03:15 EST



Gustavo,

> In preparation to enabling -Wimplicit-fallthrough, mark switch cases
> where we are expecting to fall through.
>
> This patch fixes the following warning:
>
> drivers/scsi/mpt3sas/mpt3sas_base.c: In function â_base_update_ioc_page1_inlinewith_perf_modeâ:
> drivers/scsi/mpt3sas/mpt3sas_base.c:4510:6: warning: this statement may fall through [-Wimplicit-fallthrough=]
> if (ioc->high_iops_queues) {
> ^
> drivers/scsi/mpt3sas/mpt3sas_base.c:4530:2: note: here
> case MPT_PERF_MODE_LATENCY:
> ^~~~
>
> Warning level 3 was used: -Wimplicit-fallthrough=3

Applied to 5.3/scsi-queue, thanks!

--
Martin K. Petersen Oracle Linux Engineering