RE: [PATCH] net: stmmac: add sanity check to device_property_read_u32_array call
From: Martin Blumenstingl
Date: Wed Jun 19 2019 - 01:18:25 EST
> Currently the call to device_property_read_u32_array is not error checked
> leading to potential garbage values in the delays array that are then used
> in msleep delays. Add a sanity check to the property fetching.
> Addresses-Coverity: ("Uninitialized scalar variable")
> Signed-off-by: Colin Ian King <colin.king@xxxxxxxxxxxxx>
I have also sent a patch  to fix initialize the array.
can you please look at my patch so we can work out which one to use?
my concern is that the "snps,reset-delays-us" property is optional,
the current dt-bindings documentation states that it's a required
property. in reality it isn't, there are boards (two examples are
mentioned in my patch: ) without it.
so I believe that the resulting behavior has to be:
1. don't delay if this property is missing (instead of delaying for
<garbage value> ms)
2. don't error out if this property is missing
your patch covers #1, can you please check whether #2 is also covered?
I tested case #2 when submitting my patch and it worked fine (even
though I could not reproduce the garbage values which are being read
on some boards)