Re: [PATCH net] net: mvpp2: prs: Don't override the sign bit in SRAM parser shift

From: Sergei Shtylyov
Date: Thu Jun 20 2019 - 05:04:00 EST

On 19.06.2019 17:54, Maxime Chevallier wrote:

The Header Parser allows identifying various fields in the packet
headers, used for for various kind of filtering and classification

One "for" is enough. :-)


This is a re-entrant process, where the offset in the packet header
depends on the previous lookup results. This offset is represented in
the SRAM results of the TCAM, as a shift to be operated.

This shift can be negative in some cases, such as in IPv6 parsing.

This commit prevents overriding the sign bit when setting the shift
value, which could cause instabilities when parsing IPv6 flows.

Fixes: 3f518509dedc ("ethernet: Add new driver for Marvell Armada 375 network unit")
Suggested-by: Alan Winkowski <walan@xxxxxxxxxxx>
Signed-off-by: Maxime Chevallier <maxime.chevallier@xxxxxxxxxxx>

MBR, Sergei