Re: [PATCH v5 4/7] i2c: core: Make i2c_acpi_get_irq available to the rest of the I2C core
From: Charles Keepax
Date: Thu Jun 20 2019 - 11:20:46 EST
On Thu, Jun 20, 2019 at 05:59:50PM +0300, Andy Shevchenko wrote:
> On Thu, Jun 20, 2019 at 02:34:17PM +0100, Charles Keepax wrote:
> > In preparation for more refactoring make i2c_acpi_get_irq available
> > outside i2c-core-acpi.c.
> > Reviewed-by: Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>
> > Reviewed-by: Mika Westerberg <mika.westerberg@xxxxxxxxxxxxxxx>
> I'm not sure Rb tags are suitable for patches 4 and 5 since the changes made.
Apologies I figured the changes were small enough will remove for
any changes in future.
> > +struct acpi_device;
> Hmm... Doesn't acpi.h define that for !ACPI case?
Pretty sure I was getting a build error in that case.
> > #ifdef CONFIG_ACPI
> > const struct acpi_device_id *
> > i2c_acpi_match_device(const struct acpi_device_id *matches,
> > struct i2c_client *client);
> > void i2c_acpi_register_devices(struct i2c_adapter *adap);
> > +
> > +int i2c_acpi_get_irq(struct acpi_device *adev);
> Since you call this afterwards with struct device from which companion is
> derived, can't we directly use struct device as a parameter?
> Yes, in case of adev call, it might be &adev->dev I suppose?
A good idea I will investigate and do a respin taking in the
other comments too.