Re: [PATCH 2/3] rtc: pcf8563: Clear event flags and disable interrupts before requesting irq
From: Alexandre Belloni
Date: Thu Jun 20 2019 - 14:37:46 EST
On 04/06/2019 12:23:36+0800, Chen-Yu Tsai wrote:
> From: Chen-Yu Tsai <wens@xxxxxxxx>
> Besides the alarm, the PCF8563 also has a timer triggered interrupt.
> In cases where the previous system left the timer and interrupts on,
> or somehow the bits got enabled, the interrupt would keep triggering
> as the kernel doesn't know about it.
> Clear both the alarm and timer event flags, and disable the interrupts,
> before requesting the interrupt line.
> Fixes: ede3e9d47cca ("drivers/rtc/rtc-pcf8563.c: add alarm support")
> Fixes: a45d528aab8b ("rtc: pcf8563: clear expired alarm at boot time")
> Signed-off-by: Chen-Yu Tsai <wens@xxxxxxxx>
> drivers/rtc/rtc-pcf8563.c | 11 +++++------
> 1 file changed, 5 insertions(+), 6 deletions(-)
Alexandre Belloni, Bootlin
Embedded Linux and Kernel engineering