Re: [PATCH v2 3/4] ARM: dts: exynos: Add regulator suspend configuration to Odroid XU3/XU4/HC1 family
From: Marek Szyprowski
Date: Mon Jun 24 2019 - 03:20:46 EST
On 2019-06-23 18:02, Anand Moon wrote:
> Thanks for this patch. Please add my
> Tested-by: Anand Moon <linux.amoon@xxxxxxxxx>
> Could you integrate below small changes into this patch.
> with these below changes suspend and resume work correctly at my end.
>  XU4_suspendresume.patch
> As per S2MPS11B PMIC 1.2.1 Regulator (Features)
> Fix the min max value for *Buck7* and *Buck8*
> -- Buck7 (VDD_1.0V_LDO) 1.5 A (1.2 V to 1.5 V, 12.5 mV step, default on 1.35 V)
> -- Buck8 (VDD_1.8V_LDO) 2.5 A (1.8 V to 2.1 V, 12.5 mV step, default on 2.0 V)
Could you elaborate why such change for Buck7 and Buck8 is needed?
> Also add suspend-off for *Buck9*
> Buck9 internally controls the power of USB hub.
> Adding suspend the this node help proper reset of USB hub on Odroid
> XU4 / HC1/ XU3
> during suspend and resume. Below it the logs from my testing.
Disabling Buck9 in suspend indeed reduces the power consumed by the
board during suspend-to-ram from about 80mA to as little as 7-10mA, what
matches the results of OdroidXU3. Thanks for the hint!
Marek Szyprowski, PhD
Samsung R&D Institute Poland