Re: [PATCH 1/6] x86/xen: Mark xen_hvm_need_lapic() and xen_hvm_need_lapic() as __init
From: Thomas Gleixner
Date: Mon Jun 24 2019 - 09:58:19 EST
On Sun, 23 Jun 2019, Zhenzhong Duan wrote:
> .. as they are only called at early bootup stage. In fact, other
> functions in x86_hyper_xen_hvm.init.* are all marked as __init.
> Unexport xen_hvm_need_lapic as it's never used outside.
Can you please provide a cover letter for your patch series and explain
what this whole exercise is about.
I'm seing some __init anotations in various files and then functional xen
changes which seem to be completely unrelated and independent.
Please split such stuff, e.g. the unrelated __init annotations so they can
be picked up and merged and the real functional stuff is then self
If the __init annotation touches the same code as the functional changes,
then keep them together, but please do not burden reviewers and maintainers
with guess work to decode what is what.