Re: [PATCH net-next] can: dev: call netif_carrier_off() in register_candev()

From: Willem de Bruijn
Date: Mon Jun 24 2019 - 13:27:00 EST

On Mon, Jun 24, 2019 at 4:34 AM Rasmus Villemoes
<rasmus.villemoes@xxxxxxxxx> wrote:
> CONFIG_CAN_LEDS is deprecated. When trying to use the generic netdev
> trigger as suggested, there's a small inconsistency with the link
> property: The LED is on initially, stays on when the device is brought
> up, and then turns off (as expected) when the device is brought down.
> Make sure the LED always reflects the state of the CAN device.
> Signed-off-by: Rasmus Villemoes <rasmus.villemoes@xxxxxxxxx>

Should this target net? Regardless of CONFIG_CAN_LEDS deprecation,
this is already not initialized properly if that CONFIG is disabled
and a can_led_event call at device probe is a noop.