Re: [PATCH RESEND] ARM: dts: qcom: msm8974-hammerhead: add device tree bindings for vibrator
From: Brian Masney
Date: Mon Jun 24 2019 - 20:54:47 EST
On Tue, Jun 25, 2019 at 12:29:29AM +0200, Linus Walleij wrote:
> On Sun, Jun 23, 2019 at 12:53 PM Brian Masney <masneyb@xxxxxxxxxxxxx> wrote:
> > 2) Do what Linus suggests above. We can use v1 of this series from last
> > September (see below for link) that adds this to the pwm subsystem.
> > The locking would need to be added so that it won't conflict with the
> > clk subsystem. This can be tied into the input subsystem with the
> > existing pwm-vibra driver.
> What I imagined was that the clk driver would double as a pwm driver.
> Just register both interfaces.
> There are already plenty of combines clk+reset drivers for example.
> Otherwise I'm all for this approach (but that's just me).
I agree that this makes sense. I especially like that it'll allow us
to use the existing pwm-vibra driver in the input subsystem with this