RE: Re: [PATCH v4 13/16] PM / devfreq: tegra: Support Tegra30
From: MyungJoo Ham
Date: Mon Jun 24 2019 - 21:42:28 EST
Sender : Dmitry Osipenko <digetx@xxxxxxxxx>
>24.06.2019 14:11, MyungJoo Ham ÐÐÑÐÑ:
>>> --------- Original Message ---------
>>> Sender : Dmitry Osipenko <digetx@xxxxxxxxx>
>>> 24.06.2019 10:34, MyungJoo Ham ÐÐÑÐÑ:
>>>>> A question:
>>>>> Does this driver support Tegra20 as well?
>>>>> I'm asking this because ARCH_TEGRA includes ARCH_TEGRA_2x_SOC
>>>>> according to /drivers/soc/tegra/Kconfig.
>>>> For this matter, how about updating your 13/16 patch as follows?
>>> Good call! I'll update this patch following yours suggestion, thanks.
>> Or, you may approve the modified commits here:
>Looks almost good to me!
>I just recalled that there is also a 64bit variant of Tegra124, the Tegra132. Hence
>the Tegra30+ Kconfig entry should look like this (it's also worthy to break the lines
>diff --git a/drivers/devfreq/Kconfig b/drivers/devfreq/Kconfig
>index ccb1a68c4b51..bd2efbc27725 100644
>@@ -94,7 +94,10 @@ config ARM_EXYNOS_BUS_DEVFREQ
> config ARM_TEGRA_DEVFREQ
> tristate "NVIDIA Tegra30/114/124/210 DEVFREQ Driver"
>- depends on ARCH_TEGRA || COMPILE_TEST
>+ depends on ARCH_TEGRA_3x_SOC || ARCH_TEGRA_114_SOC || \
>+ ARCH_TEGRA_132_SOC || ARCH_TEGRA_124_SOC || \
>+ ARCH_TEGRA_210_SOC || \
> select PM_OPP
> This adds the DEVFREQ driver for the Tegra family of SoCs.
>Could you please adjust the patches like I'm suggesting? I'll approve yours change
>then and won't re-spin the first batch of the patches.
I've adjusted as you suggested. It's pushed to the git repo as well.